wasphin opened a new pull request, #3515:
URL: https://github.com/apache/brpc/pull/3515
### What problem does this PR solve?
Issue Number: N/A
Problem Summary:
Processing an RTMP Abort command currently deletes the target chunk stream.
This also discards its previous message header, so later compressed chunk
headers cannot be decoded. Ignoring an Abort that targets the currently
parsed chunk stream also leaves the intended state transition implicit.
### What is changed and the side effects?
Changed:
Reset the target chunk stream's incomplete message while preserving the chunk
stream and its previous message header. Extend the RTMP regression test to
cover aborting both the current and a different chunk stream.
Side effects:
- Performance effects: None expected. Abort now resets existing state instead
of deleting and potentially recreating the chunk stream.
- Breaking backward compatibility: No.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
