wasphin commented on code in PR #3515:
URL: https://github.com/apache/brpc/pull/3515#discussion_r3915427464
##########
src/brpc/policy/rtmp_protocol.cpp:
##########
@@ -879,8 +879,7 @@ void RtmpContext::ClearChunkStream(uint32_t cs_id) {
LOG(ERROR) << "chunk_stream_id=" << cs_id << " does not exist";
return;
Review Comment:
The ERROR-level diagnostic for a missing chunk stream is existing
ClearChunkStream behavior, not introduced by this change. An Abort is expected
to identify a chunk stream with an in-progress message, so a missing target
remains useful protocol-state diagnostics. I would keep the current logging
behavior and avoid changing log policy in this focused state-preservation fix.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
