zchuango commented on code in PR #3514:
URL: https://github.com/apache/brpc/pull/3514#discussion_r3912705327
##########
src/brpc/selective_channel.cpp:
##########
@@ -394,8 +395,14 @@ void SubDone::Run() {
main_cntl->_error_code = _cntl._error_code;
} else {
if (_cntl._response != main_cntl->_response) {
- main_cntl->_response->GetReflection()->Swap(
- main_cntl->_response, _cntl._response);
+ NonreflectableMessageBase* nr_msg =
+ dynamic_cast<NonreflectableMessageBase*>(main_cntl->_response);
+ if (nr_msg != nullptr) {
+ CHECK(nr_msg->CopyFromSameType(*_cntl._response));
+ } else {
+ main_cntl->_response->GetReflection()->Swap(
+ main_cntl->_response, _cntl._response);
+ }
Review Comment:
Handled in the latest update. CopyFromSameType failure now sets ERESPONSE
instead of aborting on CHECK.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
