cw20050111-prog commented on code in PR #3514:
URL: https://github.com/apache/brpc/pull/3514#discussion_r3923019970
##########
src/brpc/nonreflectable_message.h:
##########
@@ -229,6 +246,17 @@ class NonreflectableMessage : public
::google::protobuf::Message {
private:
static T _instance;
+#if GOOGLE_PROTOBUF_VERSION >= 5029000
+ static void* PlacementNew_(const void*, void* mem,
Review Comment:
Thanks for taking a look. I may be misunderstanding this comment, but there
doesn’t appear to be a space between `PlacementNew_` and `(` in my original
code. Could you please clarify what issue or change you’re referring to here?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]