Copilot commented on code in PR #3524:
URL: https://github.com/apache/brpc/pull/3524#discussion_r3952298441
##########
src/brpc/details/http_message.cpp:
##########
@@ -49,6 +49,9 @@ DEFINE_int32(http_verbose_max_body_length, 512,
DEFINE_bool(http_check_outbound_header_crlf, true,
"Skip outbound http header fields whose name or value contains "
"CR/LF to prevent request/response splitting.");
+DEFINE_uint32(http_max_header_count, 100,
+ "Reject a message carrying more than so many header fields. "
+ "0 lifts the limit.");
Review Comment:
The gflags help text for this new limit is user-facing but currently uses an
awkward phrasing ("more than so many"). Rewording slightly would make the flag
intent clearer for operators.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
