Copilot commented on code in PR #3524:
URL: https://github.com/apache/brpc/pull/3524#discussion_r3998436220
##########
src/brpc/uri.h:
##########
@@ -56,7 +56,7 @@ class URI {
// You can copy a URI.
URI();
- ~URI();
+ ~URI() = default;
Review Comment:
`URI` is an end-user public class, and moving its destructor from `uri.cpp`
into this header removes the out-of-line `brpc::URI::~URI()` ABI symbol that
existing binaries may reference. Keep the declaration and out-of-line
definition (or explicitly version/document this ABI break) rather than making
this unrelated public ABI change.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
