This is an automated email from the ASF dual-hosted git repository.
chenBright pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/brpc.git
The following commit(s) were added to refs/heads/master by this push:
new df0f7ace Fix stream count test cleanup (#3531)
df0f7ace is described below
commit df0f7acec5c159c98102d21a3ec3a07c2efeb4f0
Author: Xiaofeng Wang <[email protected]>
AuthorDate: Tue Sep 8 14:02:55 2026 +0800
Fix stream count test cleanup (#3531)
* Fix stream count test cleanup
* Assert stream cleanup succeeds in the test
---
test/brpc_streaming_rpc_unittest.cpp | 8 ++++++--
1 file changed, 6 insertions(+), 2 deletions(-)
diff --git a/test/brpc_streaming_rpc_unittest.cpp
b/test/brpc_streaming_rpc_unittest.cpp
index 5a49de69..e4064228 100644
--- a/test/brpc_streaming_rpc_unittest.cpp
+++ b/test/brpc_streaming_rpc_unittest.cpp
@@ -1388,7 +1388,7 @@ public:
brpc::Controller* cntl = static_cast<brpc::Controller*>(controller);
response->set_message(request->message());
- brpc::StreamIds response_streams;
+ response_streams.clear();
accept_result.store(
brpc::StreamAccept(response_streams, *cntl, nullptr),
std::memory_order_release);
@@ -1398,6 +1398,7 @@ public:
std::atomic<int> accept_result{0};
std::atomic<size_t> accepted_streams{0};
+ brpc::StreamIds response_streams;
};
TEST_F(StreamingRpcTest, limit_streams_accepted_per_request) {
@@ -1446,8 +1447,11 @@ TEST_F(StreamingRpcTest,
limit_streams_accepted_per_request) {
std::memory_order_acquire));
}
+ for (brpc::StreamId stream_id : service.response_streams) {
+ ASSERT_EQ(0, brpc::StreamClose(stream_id));
+ }
for (brpc::StreamId stream_id : request_streams) {
- brpc::StreamClose(stream_id);
+ ASSERT_EQ(0, brpc::StreamClose(stream_id));
}
}
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
