wasphin opened a new pull request, #3536:
URL: https://github.com/apache/brpc/pull/3536
### What problem does this PR solve?
Issue Number:
Problem Summary:
The MySQL response parser reads the response type byte without first
rejecting packets whose declared payload length is zero. When another packet
follows, the parser may treat that packet's first byte as the empty packet's
type.
### What is changed and the side effects?
Changed:
- Reject zero-length MySQL response packets before reading their type.
- Apply the same validation after a fast-auth marker.
- Cover standalone and followed-by-another-packet cases.
Side effects:
- Performance effects: One payload-length check while determining a response
type.
- Breaking backward compatibility: Invalid zero-length response packets are
rejected instead of being interpreted using following bytes.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
