darion-yaphet opened a new pull request, #3594: URL: https://github.com/apache/brpc/pull/3594
### What problem does this PR solve? Problem Summary: When `WITH_BORINGSSL` is enabled, missing dependencies do not immediately stop configuration because `find_package(BoringSSL)` is not marked `REQUIRED`. The finder also validates a combined library list, which can incorrectly report success when the SSL library is missing but the Crypto library is present. ### What is changed and the side effects? Changed: - Require BoringSSL when `WITH_BORINGSSL` is enabled. - Validate the include directory, SSL library, and Crypto library separately. - Stop during dependency discovery and identify the missing components. Side effects: - Incomplete BoringSSL installations now fail earlier with clearer diagnostics. - Performance effects: None; the changes affect CMake configuration only. - Breaking backward compatibility: None for valid dependency configurations. *** ### Check List: - [x] Validated isolated CMake checks for missing headers, missing SSL, missing Crypto, and all required variables present. - [x] `git diff --check` passed. - [ ] Full compilation has not been run. - This change is a build-configuration fix; no new runtime feature is introduced. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
