Copilot commented on code in PR #3594:
URL: https://github.com/apache/brpc/pull/3594#discussion_r4232313829
##########
cmake/FindBoringSSL.cmake:
##########
@@ -63,8 +63,9 @@ set(BORINGSSL_LIBRARIES ${BORINGSSL_SSL_LIBRARY}
${BORINGSSL_CRYPTO_LIBRARY}
include(FindPackageHandleStandardArgs)
find_package_handle_standard_args(BoringSSL DEFAULT_MSG
Review Comment:
`find_package_handle_standard_args` is being used with the legacy
`DEFAULT_MSG` signature (implicit required vars). For clearer intent and better
forward-compatibility with newer CMake behavior, consider switching to the
modern form that explicitly uses `REQUIRED_VARS` (and omit `DEFAULT_MSG`). This
reduces the risk of argument mis-parsing and makes the required inputs
unambiguous.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
