Copilot commented on code in PR #3596:
URL: https://github.com/apache/brpc/pull/3596#discussion_r4238310300
##########
.github/workflows/ci-linux.yml:
##########
@@ -115,6 +115,18 @@ jobs:
"${cmake_options[@]}"
cmake --build build -j ${{env.proc_num}}
+ - name: Check installed component consumers
+ if: matrix.name == 'gcc-default' || matrix.name == 'clang-default'
Review Comment:
The consumer check only runs for the two default Linux configurations, while
the all-options jobs do not enable component libraries at all. Consequently,
the newly added package branches for glog, Thrift, RDMA, ubring, bthread
tracing/Abseil, and ASAN are never configured, installed, or consumed; the
macOS-specific component linkage/RPATH path is also untested. Please add
component-consumer coverage for representative optional-feature and macOS
builds, since these exported dependency closures are part of the new public
behavior.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
