wasphin commented on code in PR #3596:
URL: https://github.com/apache/brpc/pull/3596#discussion_r4242179301
##########
example/cmake/BrpcExample.cmake:
##########
@@ -29,7 +29,7 @@ endfunction()
macro(brpc_example_find_common_deps out_libs)
execute_process(
- COMMAND bash -c "find ${PROJECT_SOURCE_DIR}/../.. -type d -regex
\".*output/include$\" | head -n1 | xargs dirname | tr -d '\n'"
+ COMMAND bash -c "find ${CMAKE_CURRENT_SOURCE_DIR}/../.. -type d -regex
\".*output/include$\" | head -n1 | xargs dirname | tr -d '\n'"
Review Comment:
Fixed both the shared example helper and the independent ubring_performance
configuration. They no longer search for output/include or overwrite the
caller's CMAKE_PREFIX_PATH. Instead, the examples use an explicit installed
prefix; the English and Chinese getting-started instructions now show
installation followed by configuring the example with that prefix.
The existing gcc-default CMake job installs the bundle into a fresh prefix,
builds the echo client/server executables against it, and configures
ubring_performance using that prefix. This check passed. The ubring check is
configuration-only, not a build or runtime test, because this job retains the
default WITH_UBRING=OFF configuration. No additional CI jobs were introduced.
CI: https://github.com/apache/brpc/actions/runs/38151687754
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
