chenBright commented on code in PR #3599:
URL: https://github.com/apache/brpc/pull/3599#discussion_r4258358501
##########
test/run_tests.sh:
##########
@@ -57,10 +68,10 @@ print_bt () {
if [ -z "$failed_test" ]; then
>&2 echo "[runtest] $test_num succeeded"
elif [ $test_num -gt 1 ]; then
- print_bt $failed_test
+ print_bt "$failed_test" "$test_pid"
>&2 echo "[runtest] '$failed_test' failed, $((test_num-1)) succeeded"
else
- print_bt $failed_test
+ print_bt "$failed_test" "$test_pid"
Review Comment:
Updated the PR description to match the PID-based core lookup and
signal-delivery coverage. A normal exit(134) and termination by SIGABRT can
produce the same shell status, so rc >= 128 cannot reliably distinguish them.
The runner therefore matches cores against the failed process’s PID.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
