chenBright commented on code in PR #3599: URL: https://github.com/apache/brpc/pull/3599#discussion_r4258328179
########## test/endpoint_unittest.cpp: ########## @@ -16,19 +16,27 @@ // under the License. #include <gtest/gtest.h> +#include <atomic> +#include <pthread.h> +#include <signal.h> Review Comment: This test file already depends on pthreads and POSIX socket APIs, and this PR targets Linux and macOS. Guarding only these includes would not provide Windows compatibility, so I’m keeping them unconditional. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
