Copilot commented on code in PR #3618:
URL: https://github.com/apache/brpc/pull/3618#discussion_r4302607831
##########
example/ubring_performance/CMakeLists.txt:
##########
@@ -100,7 +95,7 @@ include_directories(${OPENSSL_INCLUDE_DIR})
set(DYNAMIC_LIB
${CMAKE_THREAD_LIBS_INIT}
${GFLAGS_LIBRARY}
- ${PROTOBUF_LIBRARIES}
+ protobuf::libprotobuf
Review Comment:
This example still declares support for CMake 2.8.10, but the legacy
FindProtobuf module on those CMake versions does not define the imported target
`protobuf::libprotobuf`. It is then passed to the linker as a literal library
name and the example fails to link; keep `${PROTOBUF_LIBRARIES}` here or raise
the example's minimum CMake version.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
