wasphin commented on code in PR #3618:
URL: https://github.com/apache/brpc/pull/3618#discussion_r4302750947
##########
example/ubring_performance/CMakeLists.txt:
##########
@@ -100,7 +95,7 @@ include_directories(${OPENSSL_INCLUDE_DIR})
set(DYNAMIC_LIB
${CMAKE_THREAD_LIBS_INIT}
${GFLAGS_LIBRARY}
- ${PROTOBUF_LIBRARIES}
+ protobuf::libprotobuf
Review Comment:
Fixed in 9e13e32e. Aligned the example’s minimum CMake version and policy
range with the root project and other examples. Configuration and both
executable builds pass without the compatibility override.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]