chenBright commented on code in PR #3647: URL: https://github.com/apache/brpc/pull/3647#discussion_r4358024205
########## src/brpc/span.h: ########## @@ -50,6 +50,11 @@ void* CreateBthreadSpanAsVoid(); void DestroyRpczParentSpan(void* ptr); void EndBthreadSpan(); +// Permanently stop span persistence and wait for any active dump to finish. +// Further dump attempts are ignored, including already queued spans. Review Comment: Partially accepted. `span.h` already explicitly states that RPC users should not include it, and this function is an internal shutdown primitive used by the exit guard and regression tests. I have clarified that it is not a supported user API, is thread-safe and idempotent, and must not be called from within an active span dump. Moving it into another header or namespace is unnecessary for this change. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
