chenBright commented on PR #3647: URL: https://github.com/apache/brpc/pull/3647#issuecomment-6362278795
The Copilot comments have been evaluated against the implementation and its call sites. Several findings were false positives, particularly the recursive-locking concern and the assumption that the new mutex reduces existing persistence parallelism. The applicable feedback has been addressed: - Added an explicit `<pthread.h>` include. - Clarified the internal API contract and calling restrictions of `StopSpanIndexing()`. - Documented the collector's existing single-threaded persistence model. This PR is ready for maintainer review. @wwbmmm PTAL. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
