songgaoye opened a new pull request, #3649:
URL: https://github.com/apache/brpc/pull/3649

   ### What problem does this PR solve?
   
   Issue Number: resolve
   
   Problem Summary:
   
   When a Baidu RPC client receives a `SerializedResponse`, its payload is 
appended from a temporary `IOBuf` using the copy-style overload. This does not 
copy payload bytes, but duplicates `IOBuf` BlockRefs and performs corresponding 
reference-count operations before the temporary buffer is destroyed.
   
   ### What is changed and the side effects?
   
   Changed:
   
   Use `IOBuf::movable()` when appending the received payload to 
`SerializedResponse`. The BlockRefs are transferred directly because the source 
buffer is not used afterwards.
   
   Side effects:
   
   - Performance effects: Reduces BlockRef traversal and reference-count 
increment/decrement operations on the serialized-response receive path. 
Benefits are expected mainly for high-QPS or fragmented/large responses.
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to