chenBright opened a new pull request, #3713:
URL: https://github.com/apache/brpc/pull/3713
### What problem does this PR solve?
Issue Number: resolve #3520
Problem Summary:
A bthread may resume on a different pthread after suspension. Compiler
optimizations can retain TLS addresses
from the previous pthread, causing incorrect accesses or crashes, including
in `bvar::AgentGroup`.
Existing TLS protection covers only some access paths and
compiler/architecture combinations.
### What is changed and the side effects?
Changed:
- Add `BUTIL_THREAD_LOCAL(type, name, ...)`, providing a reference-returning
accessor for reads, writes,
and address access.
- Use `noinline` and an opaque inline-assembly output to prevent TLS address
caching across suspension,
including under LTO.
- Migrate TLS access across brpc, bthread, butil, and bvar, including
initialization and cleanup paths.
- Remove compiler and architecture restrictions from legacy TLS access
macros so they always call the
protected accessors.
Side effects:
- Performance effects:
- Breaking backward compatibility:
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]