Spicy-cream opened a new pull request, #3712:
URL: https://github.com/apache/brpc/pull/3712

   **What problem does this PR solve?**
   
   URMA selects a process-wide Jetty priority. Applications need independent 
outgoing QoS settings for each business channel and server.
   
   This PR depends on [PR3708](https://github.com/apache/brpc/pull/3708). The 
source branch includes its recovery changes; merge PR3708 first. The [QoS-only 
comparison](https://github.com/LinQuickDev/brpc/compare/feature/rdma-runtime-recovery...feature/rdma-business-qos)
 shows the increment developed in [LinQuickDev 
PR93](https://github.com/LinQuickDev/brpc/pull/93).
   
   **What is changed and the side effects?**
   
   - Add ChannelOptions and ServerOptions settings for outgoing SL 0-255 and 
priority 0-15; -1 selects automatic behavior. Channels configure request 
traffic, and servers configure response traffic.
   - Resolve SL through the selected CTP/RTP device mapping. Reject 
unsupported, conflicting or out-of-range settings during Channel initialization 
or Server startup, with supported priority:SL pairs in diagnostics.
   - Include QoS in connection signatures and propagate it through naming 
services, accepted sockets and rebuilt Jettys. Use prepared Jettys only when 
their priority matches.
   - Propagate QoS through GetSubSocketOptions() so pooled/short children 
retain QoS alongside keepalive, TCP user timeout and bthread tag settings.
   - Expose requested/effective values in diagnostics and examples, and add 
independent QoS and connection-lifecycle regressions.
   
   Different configurations use separate connections and Jetty resources. 
Defaults retain automatic URMA selection. Existing v2/v3 wire formats remain 
compatible.
   
   **Validation**
   
   - The [URMA mock 
workflow](https://github.com/LinQuickDev/brpc/actions/runs/41773760009) passes 
all 21 regression groups with RDMA disabled and URMA enabled, including the 
inherited 8 server-SEND recovery cases. License Check also passed.
   - A regression verifies QoS, keepalive snapshots, TCP user timeout and 
bthread tag propagation to pooled and short sockets. All 3 existing community 
Socket option tests passed; their sources remain unchanged.
   - Library/example builds and C++14 compilation checks passed, including 
public headers with transports disabled.
   - Mock lifecycle regressions cover small-pool v2/v3 short connections and 
request SL 4/response SL 2 across TCP cooldown and fresh URMA connections.
   - Prior URMA RM/RTP hardware runs passed all 12 event/polling, v2/v3 and 
auto/SL/SL-plus-priority RPC cases, plus all 6 client/server 
configuration-rejection cases. A live server connection reported ESTABLISHED 
with effective priority 2 and SL 2.
   
   Design discussion: [URMA runtime recovery and business QoS 
configuration](https://github.com/apache/brpc/discussions/3711).
   
   **Check List**
   
   - [x] Build the library/examples and run related regressions.
   - [x] Add independent tests, preserve existing community UT sources and 
update documentation.
   - [x] Follow four-space indentation and C++ nullptr conventions.
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to