songgaoye opened a new pull request, #3724:
URL: https://github.com/apache/brpc/pull/3724

   ### What problem does this PR solve?
   
   Issue Number: resolve 
   
   Problem Summary:
   
   In C++14 builds, `butil::optional<T>` uses a custom implementation whose 
defaulted copy and move operations copy raw storage. For non-trivial types such 
as `std::string`, this can cause a double-free.
   
   ### What is changed and the side effects?
   
   Changed:
   
   - Construct, assign, and destroy the contained value correctly during copy 
and move operations.
   - Make move operations conditionally `noexcept` based on `T`.
   - Add lifetime regression tests and an explicit C++14 ASan/UBSan CI check.
   
   Side effects:
   
   - Performance effects: Copy and move operations now invoke the contained 
type's operations instead of copying raw storage.
   
   - Breaking backward compatibility: No intended API break. Copy/move type 
traits for unsupported operations remain outside the scope of this change.
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to