songgaoye commented on code in PR #3724:
URL: https://github.com/apache/brpc/pull/3724#discussion_r4570774534
##########
.github/workflows/ci-linux.yml:
##########
@@ -387,6 +387,13 @@ jobs:
- uses: ./.github/actions/init-ut-make-config
with:
options: --with-bthread-tracer --with-asan
+ - name: Test C++14 optional with sanitizers
+ run: |
+ clang++-12 -std=c++14 -DBRPC_TEST_OPTIONAL_CXX14 \
+ -fsanitize=address,undefined -fno-omit-frame-pointer -I src \
+ test/optional_unittest.cpp -lgtest_main -lgtest -pthread \
Review Comment:
This is already handled by the job setup: it installs clang-12 and
libgtest-dev, and init-ut-make-config builds GoogleTest with clang-12 and
installs the libraries into /usr/lib before this step runs
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]