songgaoye opened a new pull request, #3729:
URL: https://github.com/apache/brpc/pull/3729
### What problem does this PR solve?
Issue Number: resolve
Problem Summary:
`IpcShmFree()` clears `SHM::addr` when `shm_unlink()` returns `ENOENT`.
However, `ENOENT` only means that the shared-memory name was already removed;
it does not unmap an existing local mapping.
A connection can unlink its local shared-memory name during the handshake,
then
reach another unlink during close before asynchronous cleanup. The second
unlink
returns `ENOENT`, clears the live mapping address, and causes the later
`IpcShmMunmap()` call to skip `munmap()`.
### What is changed and the side effects?
Changed:
- Keep `SHM::addr` intact when `IpcShmFree()` observes `ENOENT`.
- Add coverage for repeated IPC unlink followed by `IpcShmMunmap()`.
Side effects:
- Performance effects:
None.
- Breaking backward compatibility:
None.
---
### Check List:
- Please make sure your changes are compilable.
- When providing us with a new feature, it is best to add related tests.
- Please follow [Contributor Covenant Code of
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]