randomkang opened a new pull request, #3732:
URL: https://github.com/apache/brpc/pull/3732

   The benchmark_fb_smoke timed-boundary assertions were too tight for shared 
GitHub runners. Two consecutive CI runs on macOS both failed with different 
assertions tripped by the same cause: scheduling and I/O jitter adds ~150 ms on 
top of the 600 ms server-side delay, so a single call takes ~750 ms end-to-end.
   
   - Run 1: seconds=2.2 hit the exclusive upper bound (was < 2.2).
   - Run 2: seconds=2.1 passed, but p50_us=750474 exceeded 700000.
   
   Widen the bounds while keeping the intent:
   
   - seconds: < 2.6 still rejects a window stretched by a whole extra call 
(~3.4 s) but tolerates one jittered in-flight call.
   - latency upper bound: use the request timeout (5 s, matching 
--timeout_ms=5000) instead of a fixed 700 ms; keep the 600 ms floor (the 
server-side delay always applies) and the p50<=max histogram ordering check.
   
   ### What problem does this PR solve?
   
   Issue Number: #3731  
   
   Problem Summary:
   
   ### What is changed and the side effects?
   
   Changed:
   
   Side effects:
   - Performance effects:
   
   - Breaking backward compatibility: 
   
   ---
   ### Check List:
   - Please make sure your changes are compilable.
   - When providing us with a new feature, it is best to add related tests.
   - Please follow [Contributor Covenant Code of 
Conduct](https://github.com/apache/brpc/blob/master/CODE_OF_CONDUCT.md).
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to