Hi all,

Happy to help out on this where I can!

> * So far, I've managed to get all our tests working with GitHub
> Actions. You can find the configuration at:
> https://github.com/cs-shadow/buildstream/blob/master/.github/workflows/ci.yml.
> Everything that I haven't ported is mostly because I haven't had time
> to do that yet. I don't see any big missing features that'd prevent us
> from adopting Actions. They do support persisting artifacts, scheduled
> jobs etc so I think we are covered.
> 
> You will also find more of my notes and rants in the above mentioned
> ci.yml file.
> 

Thanks for the notes Chandan, it makes it really easy to follow. There are 3 
things that I can have a prod at:

- "GitHub Actions do not support YAML variables and/or YAML anchors, which
   leads to some repetition." Yeh I think that this is a problem. So the way 
buildbarn approach this is to use jsonnet to generate the github actions, which 
I think is an effective route 
https://github.com/buildbarn/bb-storage/commit/41a7e29dfebb625729a0c4f0e8285a254781e698#diff-02d9c370a663741451423342d5869b21
 I'm happy to experiement with such an approach and report back.

- wsl tasks (TODO: Check if GitHub's Windows runners allow WSL). From 
https://github.com/actions/virtual-environments/issues/50#issuecomment-663462963
 it appears that the answer is "yes". I can have a play with this too.

- "persistent artifact cache" So I know that there have been efforts in this 
area via https://gitlab.com/BuildStream/buildstream/-/merge_requests/1997 (now 
merged) and more recently with the asset cache at 
https://gitlab.com/BuildStream/infrastructure/infrastructure/-/merge_requests/2.
 It's probably worth coordinating with the authors of both MRs to smooth the 
transition.

On a broader point, is there anywhere we can track and review each other's 
work? I'm happy to work off https://github.com/cs-shadow/buildstream but other 
locations work for me.

Many thanks,

Chris

Reply via email to