Hi Chris, Many thanks for looking into this. I generally like this idea, especially because it also makes it easier to reproduce the tests locally. So, +1 for moving the core logic out of platform-specific YAML files into something more generic.
Your patch seems good. I have left a few comments about that on your pull request. > - Moving the overnight tests into its own workflow with a different trigger. > This may require moving the pattern of invoking the docker-compose file into > its own custom action so it can be reused by different workflows. Afaict you > can't have multiple jobs within a single workflow operate off different > triggers like you can with gitlab, although happy to be wrong in that > assertion! I would actually prefer moving overnight tests into a separate job. Having to call Compose twice from two (or maybe more) workflows doesn't seem too bad to me. Hopefully it'll be a one-liner. This is also good from a separation of concerns perspective - keeping pre-merge checks separate from post-merge overnight checks. Thanks, Chandan
