On Fri, Oct 5, 2012 at 2:46 AM, <[email protected]> wrote: > Author: mbenson > Date: Fri Oct 5 07:46:21 2012 > New Revision: 1394397 > > URL: http://svn.apache.org/viewvc?rev=1394397&view=rev > Log: > reorg some poms; remove refs to slf4j; remove exclusion of > commons-logging--this is the responsibility of the user > > Modified: > bval/trunk/bval-jsr303/pom.xml > bval/trunk/bval-xstream/pom.xml > bval/trunk/pom.xml > > Modified: bval/trunk/bval-jsr303/pom.xml > URL: > http://svn.apache.org/viewvc/bval/trunk/bval-jsr303/pom.xml?rev=1394397&r1=1394396&r2=1394397&view=diff > ============================================================================== > --- bval/trunk/bval-jsr303/pom.xml (original) > +++ bval/trunk/bval-jsr303/pom.xml Fri Oct 5 07:46:21 2012 > @@ -122,18 +122,6 @@ > <groupId>org.apache.commons</groupId> > <artifactId>commons-lang3</artifactId> > </dependency> > - <dependency> > - <groupId>junit</groupId> > - <artifactId>junit</artifactId> > - <version>3.8.2</version> > - <scope>test</scope> > - </dependency> > - <dependency> > - <groupId>org.mockito</groupId> > - <artifactId>mockito-core</artifactId> > - <scope>test</scope> > - </dependency> > - > <!-- optional dependencies --> > <dependency> > <groupId>org.apache.bval</groupId> > @@ -151,16 +139,17 @@ > <optional>true</optional> > </dependency> > <!-- Testing dependencies --> > - <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>jcl-over-slf4j</artifactId> > - <scope>test</scope> > - </dependency> > - <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>slf4j-simple</artifactId> > - <scope>test</scope> > - </dependency> > + <dependency> > + <groupId>junit</groupId> > + <artifactId>junit</artifactId> > + <version>3.8.2</version> > + <scope>test</scope> > + </dependency> > + <dependency> > + <groupId>org.mockito</groupId> > + <artifactId>mockito-core</artifactId> > + <scope>test</scope> > + </dependency> > </dependencies> > > <build> > > Modified: bval/trunk/bval-xstream/pom.xml > URL: > http://svn.apache.org/viewvc/bval/trunk/bval-xstream/pom.xml?rev=1394397&r1=1394396&r2=1394397&view=diff > ============================================================================== > --- bval/trunk/bval-xstream/pom.xml (original) > +++ bval/trunk/bval-xstream/pom.xml Fri Oct 5 07:46:21 2012 > @@ -48,16 +48,6 @@ > </dependency> > <!-- Test dependencies --> > <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>slf4j-simple</artifactId> > - <scope>test</scope> > - </dependency> > - <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>jcl-over-slf4j</artifactId> > - <scope>test</scope> > - </dependency> > - <dependency> > <groupId>junit</groupId> > <artifactId>junit</artifactId> > <scope>test</scope> > > Modified: bval/trunk/pom.xml > URL: > http://svn.apache.org/viewvc/bval/trunk/pom.xml?rev=1394397&r1=1394396&r2=1394397&view=diff > ============================================================================== > --- bval/trunk/pom.xml (original) > +++ bval/trunk/pom.xml Fri Oct 5 07:46:21 2012 > @@ -315,12 +315,6 @@ > <groupId>commons-beanutils</groupId> > <artifactId>commons-beanutils-core</artifactId> > <version>1.8.3</version> > - <exclusions> > - <exclusion> > - <groupId>commons-logging</groupId> > - <artifactId>commons-logging</artifactId> > - </exclusion> > - </exclusions> > </dependency> > <dependency> > <groupId>com.thoughtworks.xstream</groupId> > @@ -349,17 +343,6 @@ > <artifactId>aopalliance</artifactId> > <version>1.0</version> > </dependency> > - <!-- Added mainly for testing --> > - <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>jcl-over-slf4j</artifactId> > - <version>1.6.1</version> > - </dependency>
Note that what we were doing here was excluding [logging] and forcing jcl-over-slf4j as a dependency, which is really overstepping our bounds. We get a dependency on [logging] via [beanutils] which we use for property management. This we could obviously do ourselves using java.beans.Introspector, but we currently also support [beanutils] DynaBeans in this fashion. I'd like to see us remove or at least modularize the DynaBeans support, again in the interest of minimizing dependencies that don't give us much value in return. We could also explore shading [logging], with or without moving [beanutils] support to a new module. Matt > - <dependency> > - <groupId>org.slf4j</groupId> > - <artifactId>slf4j-simple</artifactId> > - <version>1.6.1</version> > - </dependency> > </dependencies> > </dependencyManagement> > > >
