PS For the aforementioned reasons, [x] -1 Do not release this package
Julian On Tue, Mar 8, 2016 at 5:11 PM, Julian Hyde <[email protected]> wrote: > I downloaded, unzipped tar.gz, built, generated the site, and tested > under Oracle 1.7 and Oracle 1.8 and (by accident) OpenJDK 1.7 on > Ubuntu. > > Problems: > > * Wrong version.minor property as previously mentioned. > > * KEYS: not present in src.tar.gz (not sure whether this is absolutely > required but it is customary). I saw that you added your key to > http://www.apache.org/dist/calcite/KEYS; that's good. Also, check the > KEYS file into git. > > * NOTICE: The last paragraph can be removed. > > * LICENSE: You removed some sections of Calcite's LICENSE relating to > the jekyll-generated files and fonts in the site that need to be > present in Avatica's LICENSE because Avatica has similar files. Change > "APACHE CALCITE SUBCOMPONENTS" to "APACHE CALCITE AVATICA > SUBCOMPONENTS". > > * We need at least a minimal README or README.md in the root directory. > > * Several binary files in site/.sass-cache. I don't think they should > be in git or the release. > > * Release notes in history.md are not complete. We recently decided in > Calcite that the release notes should state which JDK and Guava > versions the software has been tested against, and I think Avatica > should do the same. > > Other remarks (not show-stoppers): > > * It doesn't pertain to this Avatica release, but can you please > remove the Protocol Buffers section from Calcite's LICENSE file, since > the next release of Calcite will no longer ship protobuf code. > > * "mvn site" fails if you have not previously run "mvn install". > > * Apostrophe in news article: "from it's previous location" > > Julian > > On Tue, Mar 8, 2016 at 4:21 PM, Julian Hyde <[email protected]> wrote: >> Yeah, let's leave the vote open for a while while I & others give it >> due diligence. >> >> On Tue, Mar 8, 2016 at 4:06 PM, Josh Elser <[email protected]> wrote: >>> FYI, I think I actually have to -1 this one myself as I just remembered that >>> I forgot to bump the minor.version property in the build from 6 to 7. I also >>> need to write a proper post for the eventual Avatica 1.7.0 on the website (I >>> left a placeholder). >>> >>> I would still be very happy to get feedback on this release since it is the >>> first of its kind. >>> >>> >>> Josh Elser wrote: >>>> >>>> Hi all, >>>> >>>> I have created a build for Apache Calcite Avatica 1.7.0, release >>>> candidate 0. >>>> >>>> Thanks to everyone who has contributed to this release. This is the >>>> first release candidate for a release that enables us to split the >>>> Avatica project away from the "traditional" Apache Calcite build. >>>> >>>> The commit to be voted upon: >>>> >>>> http://git-wip-us.apache.org/repos/asf/calcite/commit/e697175ac6faef1ed5204a9de1adb8b30a850ec4 >>>> >>>> >>>> Its hash is e697175ac6faef1ed5204a9de1adb8b30a850ec4. >>>> >>>> The artifacts to be voted on are located here: >>>> >>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-avatica-1.7.0-rc0/ >>>> >>>> >>>> The hashes of the artifacts are as follows: >>>> src.tar.gz.md5 10034a947606a16e5aeb868cf36628d2 >>>> src.tar.gz.sha1 82707a54bf12ce46974e9acabca9a8fbb3f5ef21 >>>> src.zip.md5 0614e28f261fd7ba9c3d693fa6d8c0aa >>>> src.zip.sha1 87dfa24fb41491ceb4aae298c48a1ac724e5d275 >>>> >>>> A staged Maven repository is available for review at: >>>> https://repository.apache.org/content/repositories/orgapachecalcite-1013 >>>> >>>> Release artifacts are signed with the following key: >>>> https://people.apache.org/keys/committer/elserj.asc >>>> >>>> Please vote on releasing this package as Apache Calcite Avatica 1.7.0. >>>> >>>> The vote is open for the next 72 hours and passes if a majority of >>>> at least three +1 PMC votes are cast. >>>> >>>> [ ] +1 Release this package as Apache Calcite Avatica 1.7.0 >>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>> [ ] -1 Do not release this package because... >>>> >>>> >>>> Here is my vote: >>>> >>>> +1 (binding) >>>> >>>> - Josh >>>> >>>
