Reviewed the patch for 1402 and +1. However, there is a test failure. I think it's an off-by-one column reference caused by CALCITE-1392, but you will need to fix the expected test output.
On Fri, Oct 7, 2016 at 1:19 PM, Jesus Camacho Rodriguez <[email protected]> wrote: > Well, I wrote the patch and I forgot too, no need to apologize :) One of the > reasons to have this release is that we can get upgrade to a new Calcite > version in Hive and thus get rid of a lot of code. Since there is only one > non-binding vote, I think I am going to check it in and create a new RC. > > Julian, could you take a look at the code? I think it is quite > straightforward to review. > > Thanks, > Jesús > > > > On 10/7/16, 9:06 PM, "Julian Hyde" <[email protected]> wrote: > >>It looks as if https://issues.apache.org/jira/browse/CALCITE-1402 >><https://issues.apache.org/jira/browse/CALCITE-1402> has a patch ready but >>didn’t make the release because i didn’t review in time; if so, I apologize. >> >> >>> On Oct 5, 2016, at 10:39 AM, Julian Hyde <[email protected]> wrote: >>> >>> Yeah, Apple Mail spell-check does that to me too. A made-up word as a >>> project name makes it easy to find on Google, difficult to write emails >>> about. >>> >>> >>>> On Oct 5, 2016, at 9:59 AM, Jesus Camacho Rodriguez >>>> <[email protected]> wrote: >>>> >>>> Obviously I meant Avatica and not Avarice in my previous email... lol >>>> >>>> -- >>>> Jesús >>>> >>>> >>>> >>>> On 10/5/16, 5:47 PM, "Julian Hyde" <[email protected]> wrote: >>>> >>>>> +1 >>>>> >>>>> I am working on CALCITE-1403. May take a while because I need to rebuild >>>>> my VM, but it will go in today. >>>>> >>>>> We can’t do 1270, because Avatica 1.9.0 does not exist yet. (My bad >>>>> flagging to to be released Calcite 1.10. I have removed that flag.) >>>>> >>>>> >>>>> Julian >>>>> >>>>> >>>>>> On Oct 4, 2016, at 11:25 PM, Jesus Camacho Rodriguez >>>>>> <[email protected]> wrote: >>>>>> >>>>>> Only outstanding issues with fix version 1.10.0 are: >>>>>> * CALCITE-1403 (Druid adapter, patch available), >>>>>> * CALCITE-1382 (ClassCastException in JDBC adapter), and >>>>>> * CALCITE-1270 (upgrade to Avatica 1.9.0). >>>>>> >>>>>> CALCITE-1403 will go in soon, and CALCITE-1382 does not seem close to >>>>>> being >>>>>> completed. Thus, unless other members feel strongly about waiting for an >>>>>> Avarice release, I will move forward and create the RC once CALCITE-1403 >>>>>> is >>>>>> in. >>>>>> >>>>>> -- >>>>>> Jesús >>>>>> >>>>>> >>>>>> >>>>>> >>>>>> On 9/30/16, 1:17 AM, "Jungtaek Lim" <[email protected]> wrote: >>>>>> >>>>>>> Great! My recent work on Storm depends on CALCITE-1386 so I'd love to >>>>>>> see >>>>>>> next release sooner. >>>>>>> Thanks all for putting the great efforts. >>>>>>> >>>>>>> Best, >>>>>>> Jungtaek Lim (HeartSaVioR) >>>>>>> >>>>>>> 2016년 9월 30일 (금) 오전 3:13, Julian Hyde <[email protected]>님이 작성: >>>>>>> >>>>>>>> +1 >>>>>>>> >>>>>>>> Master branch is in good shape right now. Some good stuff has gone in >>>>>>>> since the release, but it is stable. >>>>>>>> >>>>>>>> I would ask committers to be cautious when committing to master for the >>>>>>>> next few days. That is, be sure to run the test suite before >>>>>>>> committing. >>>>>>>> Run under both JDK 1.7 and 1.8 if practical. >>>>>>>> >>>>>>>> Julian >>>>>>>> >>>>>>>> >>>>>>>>> On Sep 29, 2016, at 11:00 AM, Jesus Camacho Rodriguez < >>>>>>>> [email protected]> wrote: >>>>>>>>> >>>>>>>>> Hi team, >>>>>>>>> >>>>>>>>> I have been working on upgrading Hive to use Calcite 1.9.0, and we >>>>>>>>> found >>>>>>>> some issues that prevent us from upgrading, e.g., CALCITE-1396, >>>>>>>> CALCITE-1397. >>>>>>>>> >>>>>>>>> Thus, I was thinking on starting a new release either tomorrow or >>>>>>>> beginning next week (I will be the release manager again). >>>>>>>>> >>>>>>>>> At first I was thinking about a bug fix release (1.9.1), but I discuss >>>>>>>> with Julian, and probably it makes sense to have a minor release 1.10.0 >>>>>>>> with everything that went into Calcite since our last release. >>>>>>>>> >>>>>>>>> If you have any comment or you have other fixes that you want in the >>>>>>>> release, please let me know. >>>>>>>>> >>>>>>>>> Thanks, >>>>>>>>> Jesús >>>>>>>> >>>>>>>> >>>>> >>>>> >>> >>
