But I can't merge other people's pull requests in github, maybe I did not have the rights to commit? Or I think we should comiit pull request to apache git first . not in github . And github can sync patches from apache mirror.
-----Original Message----- From: Jesus Camacho Rodriguez [mailto:jcamachorodrig...@hortonworks.com] On Behalf Of Jesus Camacho Rodriguez Sent: Friday, June 23, 2017 5:42 PM To: zhiqiang; dev@calcite.apache.org Cc: jcama...@apache.org; els...@apache.org Subject: Re: How to merge pull request in github? If I understand your question right, you should probably rebase the PR before merging it into master. Then you should add to the commit message the reference to the PR, e.g., Close apache/calcite#xxx, and it will appear as merged. -Jesús On 6/23/17, 10:22 AM, "zhiqiang" <zhiqian...@apache.org> wrote: >Hi all > How to merge pull requests in calcite github? > I saw all pull request was closed. but not merged in github. > All commits can be found in: > https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=summary > but how to commit codes to apache git? > >Regards >Zhiqiang He >
