Right -- you cannot click the "Merge" button in the Github UI.
Typically, you will pull down their changes locally, commit/test/verify
them, and then push them to the Apache Git repo.
Using the little trick "Closes apache/calcite#xxx" that Jesús mentioned,
the pullrequest will be automatically closed after the commit is
mirrored from the ASF back to Github.
On 6/23/17 7:32 AM, Jesus Camacho Rodriguez wrote:
The writable git repo is here:
https://git-wip-us.apache.org/repos/asf/calcite.git
GitHub will indeed mirror that repo.
You can find more information about git at the ASF here:
https://git.apache.org/
-Jesús
On 6/23/17, 10:57 AM, "zhiqiang" <[email protected]> wrote:
But I can't merge other people's pull requests in github, maybe I did not have
the rights to commit?
Or I think we should comiit pull request to apache git first . not in github .
And github can sync patches from apache mirror.
-----Original Message-----
From: Jesus Camacho Rodriguez [mailto:[email protected]] On
Behalf Of Jesus Camacho Rodriguez
Sent: Friday, June 23, 2017 5:42 PM
To: zhiqiang; [email protected]
Cc: [email protected]; [email protected]
Subject: Re: How to merge pull request in github?
If I understand your question right, you should probably rebase
the PR before merging it into master.
Then you should add to the commit message the reference to the PR,
e.g., Close apache/calcite#xxx, and it will appear as merged.
-Jesús
On 6/23/17, 10:22 AM, "zhiqiang" <[email protected]> wrote:
Hi all
How to merge pull requests in calcite github?
I saw all pull request was closed. but not merged in github.
All commits can be found in:
https://git1-us-west.apache.org/repos/asf?p=calcite.git;a=summary
but how to commit codes to apache git?
Regards
Zhiqiang He
