Thanks for the help. Yes, when calcite is built before running "mvn site" without "clean" it succeeds.
Kind regards, Volodymyr Vysotskyi чт, 28 черв. 2018 о 23:25 Andrei Sereda <[email protected]> пише: > You need to build and install core module first. CalciteAssert is part of > core-test jar. > > $ cd core && mvn -DskipTests clean install > > Then run site task in mongodb. > > Let me know if it helps. > > > On Thu, Jun 28, 2018 at 4:19 PM Volodymyr Vysotskyi <[email protected]> > wrote: > > > Error message is: > > > > [ERROR] Failed to execute goal > > org.apache.maven.plugins:maven-site-plugin:3.7:site (default-site) on > > project calcite-mongodb: Error generating > > maven-javadoc-plugin:3.0.1:test-javadoc report: > > [ERROR] Exit code: 1 - > > > > > /home/user515050/work/batch_commits/calcite/mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java:22: > > error: cannot find symbol > > [ERROR] import org.apache.calcite.test.CalciteAssert; > > [ERROR] ^ > > [ERROR] symbol: class CalciteAssert > > [ERROR] location: package org.apache.calcite.test > > [ERROR] > > > > > /home/user515050/work/batch_commits/calcite/mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java:140: > > error: package CalciteAssert does not exist > > [ERROR] private CalciteAssert.AssertThat assertModel(String model) { > > [ERROR] ^ > > [ERROR] > > > > > /home/user515050/work/batch_commits/calcite/mongodb/src/test/java/org/apache/calcite/adapter/mongodb/MongoAdapterTest.java:148: > > error: package CalciteAssert does not exist > > [ERROR] private CalciteAssert.AssertThat assertModel(URL url) { > > [ERROR] ^ > > [ERROR] > > > > > /home/user515050/work/batch_commits/calcite/mongodb/src/test/java/org/apache/calcite/test/MongoAssertions.java:44: > > error: reference not found > > [ERROR] * Similar to {@link CalciteAssert#checkResultUnordered}, but > > filters strings > > [ERROR] ^ > > [ERROR] > > > > > /home/user515050/work/batch_commits/calcite/mongodb/src/test/java/org/apache/calcite/test/MongoAssertions.java:36: > > error: reference not found > > [ERROR] * Util class which needs to be in the same package as {@link > > CalciteAssert} > > [ERROR] ^ > > > > Kind regards, > > Volodymyr Vysotskyi > > > > > > чт, 28 черв. 2018 о 23:07 Andrei Sereda <[email protected]> пише: > > > > > What exactly is the error message ? > > > > > > On Thu, Jun 28, 2018 at 4:01 PM Volodymyr Vysotskyi < > > [email protected]> > > > wrote: > > > > > > > Just to clarify: in my previous letter, I meant that only "mvn > > > > javadoc:javadoc > > > > javadoc:test-javadoc" was fixed. > > > > But "mvn clean -DskipTests site" fails on my PC as before. > > > > > > > > Kind regards, > > > > Volodymyr Vysotskyi > > > > > > > > > > > > чт, 28 черв. 2018 о 01:03 Andrei Sereda <[email protected]> пише: > > > > > > > > > Submitted PR-744 <https://github.com/apache/calcite/pull/744> to > > > unify > > > > > ES2 > > > > > and ES5. > > > > > Javadoc Classpath collisions shouldn't happen anymore. > > > > > > > > > > On Mon, Jun 25, 2018 at 8:51 PM Michael Mior <[email protected]> > > wrote: > > > > > > > > > > > Thanks! > > > > > > -- > > > > > > Michael Mior > > > > > > [email protected] > > > > > > > > > > > > > > > > > > > > > > > > Le lun. 25 juin 2018 à 20:17, Julian Hyde <[email protected]> a > > > écrit : > > > > > > > > > > > > > I’m reviewing and testing just the package-exclusion part now. > > > > > Hopefully > > > > > > > will commit shortly. > > > > > > > > > > > > > > > On Jun 25, 2018, at 2:11 PM, Andrei Sereda <[email protected] > > > > > > wrote: > > > > > > > > > > > > > > > > PS. ES2+ES5 changes will be submitted in a couple of days. > > > > > > > > > > > > > > > > On Mon, Jun 25, 2018 at 4:56 PM Andrei Sereda > <[email protected] > > > > > > > > > wrote: > > > > > > > > > > > > > > > >> Temporary excluded elasticsearch2 package from javadoc. This > > > > should > > > > > > > >> unblock users. > > > > > > > >> Tested with JDK 8,9 and 10 (maven 3.5.2 / 3.5.4) macOSX > > > > > > > >> > > > > > > > >> Please double-check PR-741 < > > > > > > https://github.com/apache/calcite/pull/741> > > > > > > > >> > > > > > > > >> CALCITE-2376 (unify ES2 and ES5) has been agreed upon with > > > > Christian > > > > > > and > > > > > > > >> Michael. Once implemented, it should automatically fix > current > > > > > > classpath > > > > > > > >> issue in javadoc. > > > > > > > >> > > > > > > > >> > > > > > > > >> On Mon, Jun 25, 2018 at 2:23 PM Andrei Sereda > > <[email protected] > > > > > > > > > > wrote: > > > > > > > >> > > > > > > > >>> OK. I'm working on it. > > > > > > > >>> > > > > > > > >>> On Mon, Jun 25, 2018 at 2:18 PM Julian Hyde < > > [email protected]> > > > > > > wrote: > > > > > > > >>> > > > > > > > >>>>> On Jun 25, 2018, at 11:11 AM, Andrei Sereda > > <[email protected] > > > > > > > > > > > wrote: > > > > > > > >>>>> > > > > > > > >>>>> Would you consider merging this partial javadoc fix (PR > 741 > > > > > > > >>>>> <https://github.com/apache/calcite/pull/741>) as > precursor > > > for > > > > > > > >>>> CALCITE-2376 ? > > > > > > > >>>>> Former PR has also fixes javadoc issues for mongo > adapter. > > > > > > > >>>> > > > > > > > >>>> No. > > > > > > > >>>> > > > > > > > >>>> I have 5 commits that I would like to merge but cannot > > because > > > > my > > > > > > > builds > > > > > > > >>>> fail. We need to fix the big problem before we do anything > > > else. > > > > > > > >>>> > > > > > > > >>>>> I'm working on CALCITE-2376 which unifies ES2 and ES5 > > > adapters. > > > > > > I'll > > > > > > > >>>> make > > > > > > > >>>>> sure it is passing both javadoc / site tasks in maven. > > > > > > > >>>> > > > > > > > >>>> Sounds very cool, but I’m not an ES expert. I think you > > should > > > > get > > > > > > > >>>> buy-in from other people who have worked on the ES > > adapter(s) > > > > > before > > > > > > > you go > > > > > > > >>>> too far down that path. > > > > > > > >>>> > > > > > > > >>>> Also, it is a big solution to a small (but urgent) > problem. > > > > Let’s > > > > > > fix > > > > > > > >>>> that problem with a quick, small fix. > > > > > > > >>>> > > > > > > > >>>>> On a separate note, do you think it makes sense to add > > > javadoc > > > > > > > >>>> generation > > > > > > > >>>>> to travis build ? > > > > > > > >>>> > > > > > > > >>>> I would love to, but IIRC, travis times out if you add > > javadoc > > > > > > > >>>> generation. > > > > > > > >>>> > > > > > > > >>>> Julian > > > > > > > >>>> > > > > > > > >>>> > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > > >
