https://issues.apache.org/jira/browse/CALCITE-2836

Kevin Risden


On Fri, Feb 8, 2019 at 3:41 PM Kevin Risden <[email protected]> wrote:

> Looks like this might just be a leftover compiler plugin in calcite-plus
> module.
>
> https://github.com/apache/calcite/pull/1038
>
> The PR above passes with a minor change of removing the compiler-plugin to
> use the top level pom defined one. The comment is out of date as well.
>
> I'll open a ticket for this and cleanup the PR title/commit message.
>
> Kevin Risden
>
>
> On Fri, Feb 8, 2019 at 2:42 PM Kevin Risden <[email protected]> wrote:
>
>> From the two builds:
>>
>>    - Working - Java version: 11.0.1, vendor: Oracle Corporation,
>>    runtime: /usr/lib/jvm/java-11-openjdk-amd64
>>    - Failed - Java version: 11.0.2, vendor: Oracle Corporation, runtime:
>>    /usr/lib/jvm/java-11-openjdk-amd64
>>
>> Testing with this locally to see how this reproduces and can look into
>> fixing.
>>
>> Kevin Risden
>>
>> On Fri, Feb 8, 2019 at 2:34 PM Kevin Risden <[email protected]> wrote:
>>
>>> I can take a look. I poked around a bit yesterday and saw the same thing
>>> about the commit not changing javadocs. Not sure if JDK 11 got updated to
>>> have this issue. I'll see what it takes to fix.
>>>
>>> Kevin Risden
>>>
>>>
>>> On Fri, Feb 8, 2019 at 2:30 PM Julian Hyde <[email protected]> wrote:
>>>
>>>> Does someone else have time to take a look?
>>>>
>>>>
>>>> > On Feb 8, 2019, at 11:17 AM, Vladimir Sitnikov <
>>>> [email protected]> wrote:
>>>> >
>>>> > Julian> Vladimir, can you please take a look?
>>>> >
>>>> > As you see, the commit did not touch "Calcite Plus", so I don't really
>>>> > think the commit is to blame here. It looks more like JDK-8212233 to
>>>> > me.
>>>> > On top of that, Calcite Plus does not build on my machine (see
>>>> > CALCITE-2816 PsTableFunction fails in Russian locale), so I've a
>>>> > half-baked excuse there as well.
>>>> >
>>>> > So I'm inlined to tentatively decline your offer.
>>>> >
>>>> > Vladimir
>>>>
>>>>

Reply via email to