We already require maven 3.5.2 (or newer) On Sat, Mar 9, 2019, 21:49 YuZhao Chan <[email protected]> wrote:
> Maven version 3.6.0 seems a too much new version, now most of the > developers use 3.2.x and 3.3.x version maven, i think it will be bad to run > fail test cases just because the maven version is old. > > Best, > YuZhao Chen > 在 2019年3月10日 +0800 AM1:28，Andrei Sereda <[email protected]>，写道： > > Greetings, > > > > > > I would like to start a gradual migration of calcite test codebase to > > [JUnit5](https://junit.org/junit5/). The plan is to do in several steps > > outlined below : > > > > 1. Upgrade maven wrapper to 3.6.0 (surefire plugin needs to work with > > JUnit5 >= 2.22.0). Maybe enforce maven 3.6.0 during builds. > > 2. Add new dependencies to maven pom (jupiter and vantage). > > 3. Migrate all basic tests to new JUnit5 API. Basic in this context means > > tests without [rules](https://github.com/junit-team/junit4/wiki/rules) > or > > [runners]( > > > https://github.com/junit-team/junit4/wiki/test-runners#runwith-annotation) > > just basic `@Test` / `@Before` / `@Ignore` annotations. Code where I can > > just apply string/replace and make it work in JUnit5. > > 4. Migrate remaining tests (with `@Parameterized` / `@ClassRule` etc.). > For > > example, I will have to write custom extensions for existing elastic / > > mongo / cassandra / geode class rules. > > > > For developers that means you will need to have a reasonably recent IDE / > > Maven: > > 1. For IntelliJ this is >= 2016.2 > > 2. For Eclipse this is >= Oxygen.1a (4.7.1a) > > 3. For Maven >= 3.6.0 (released on 2018-10-24) > > > > Questions to fellow calcitians: > > > > 1. Do you agree with JUnit5 migration ? > > 2. Do you agree with the plan ? > > 3. Should I wait for 1.20 release ? > > 4. Anything I missed ? > > > > Regards, > > Andrei. >
