+1 On macOS 10.14.5, openjdk 11.0.2: - Built and ran unit tests from tarball OK - Built and ran unit tests from target commit 3979b460c OK - Checked signatures and hashes OK
Thanks Michael! Hongze > On Jun 21, 2019, at 06:42, Michael Mior <[email protected]> wrote: > > Thanks for noting the issue in the license. I agree that we can > correct this after the release. > -- > Michael Mior > [email protected] > > Le jeu. 20 juin 2019 à 15:53, Vladimir Sitnikov > <[email protected]> a écrit : >> >> Checked GPG signature - OK >> Checked hash - OK >> Release notes - OK >> >> +1 (binding) >> >> In general I support the release, however LICENSE file is slightly out of >> date. >> >> The license contains the following: >> - site/_sass/_font-awesome.scss >> Font-awesome css files v4.1.0 ( >> http://fortawesome.github.io/Font-Awesome/) >> >> In fact, the included library is v4.2.0. >> That however is a minor issue and I guess it can be corrected in the future. >> >> Vladimir
