Windows 10 Pro, jdk1.8.0_202, maven 3.6.1 * Checked signatures and checksums OK * Went over release note OK I've noticed that the contributors (non committers) names do not appear in the release note. I had the impression that the purpose of adding their name in the commit message was mainly for this reason but maybe I'm wrong. * Run unit tests (mvn clean install) on git repo and staged sources OK * Run IT tests (mvn -Dtest=foo -DfailIfNoTests=false -Pit verify -fn) KO [ERROR] Tests run: 296, Failures: 1, Errors: 0, Skipped: 18, Time elapsed: 32.112 s <<< FAILURE! - in org.apache.calcite.test.JdbcTest (mysql) [ERROR] Tests run: 36, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 5.838 s <<< FAILURE! - in org.apache.calcite.test.JdbcAdapterTest (postgresql) see CALCITE-2918 [ERROR] Tests run: 296, Failures: 0, Errors: 1, Skipped: 18, Time elapsed: 53.193 s <<< FAILURE! - in org.apache.calcite.test.JdbcTest (postgresql) see CALCITE-2918 [ERROR] Tests run: 235, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 65.878 s <<< FAILURE! - in org.apache.calcite.test.DruidAdapterIT see CALCITE-2804 [ERROR] Tests run: 31, Failures: 1, Errors: 0, Skipped: 6, Time elapsed: 2.355 s <<< FAILURE! - in org.apache.calcite.test.MongoAdapterIT see CALCITE-3120 * Run slow tests (mvn clean install -Dcalcite.test.slow -fn) KO [ERROR] Tests run: 12620, Failures: 0, Errors: 6, Skipped: 6310, Time elapsed: 2,522.456 s <<< FAILURE! - in org.apache.calcite.test.FoodmartTest (SOE + Timeouts) [ERROR] Tests run: 256, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 10.448 s <<< FAILURE! - in org.apache.calcite.sql.test.SqlOperatorTest [ERROR] Tests run: 17, Failures: 1, Errors: 0, Skipped: 0, Time elapsed: 49.711 s <<< FAILURE! - in org.apache.calcite.test.CoreQuidemTest (Intermittent failures/Plan comparison) [ERROR] Tests run: 256, Failures: 0, Errors: 1, Skipped: 1, Time elapsed: 19.759 s <<< FAILURE! - in org.apache.calcite.test.CalciteSqlOperatorTest [ERROR] Tests run: 11, Failures: 1, Errors: 0, Skipped: 7, Time elapsed: 8.132 s <<< FAILURE! - in org.apache.calcite.adapter.tpcds.TpcdsTest (Stale plans) * Run tests on downstream project OK
The new failures in the IT tests (CALCITE-2804 and CALCITE-3120) are not regressions but rather omissions to update the IT tests so I don't find them blocking. Slow tests have been failing for the past few releases so I don't consider them blocking either but we should try to fix them for the next release. Thanks a lot Michael! +1 (binding) On Fri, Jun 21, 2019 at 5:16 PM Hongze Zhang <[email protected]> wrote: > +1 > > On macOS 10.14.5, openjdk 11.0.2: > - Built and ran unit tests from tarball OK > - Built and ran unit tests from target commit 3979b460c OK > - Checked signatures and hashes OK > > Thanks Michael! > > Hongze > > > On Jun 21, 2019, at 06:42, Michael Mior <[email protected]> wrote: > > > > Thanks for noting the issue in the license. I agree that we can > > correct this after the release. > > -- > > Michael Mior > > [email protected] > > > > Le jeu. 20 juin 2019 à 15:53, Vladimir Sitnikov > > <[email protected]> a écrit : > >> > >> Checked GPG signature - OK > >> Checked hash - OK > >> Release notes - OK > >> > >> +1 (binding) > >> > >> In general I support the release, however LICENSE file is slightly out > of > >> date. > >> > >> The license contains the following: > >> - site/_sass/_font-awesome.scss > >> Font-awesome css files v4.1.0 ( > >> http://fortawesome.github.io/Font-Awesome/) > >> > >> In fact, the included library is v4.2.0. > >> That however is a minor issue and I guess it can be corrected in the > future. > >> > >> Vladimir > >
