I agree with both points. The source code should be what unprocessed, but since Windows and Linux/macOS users get different source code anyway, I'm not opposed to having two archives with different line endings. This is mostly unrelated, but at some point, I would be interested in exploring producing reproducible builds of Calcite/Avatica. If we did this, hopefully we could have identical JARs produced regardless of source line endings. -- Michael Mior [email protected]
Le jeu. 12 déc. 2019 à 10:47, Vladimir Sitnikov <[email protected]> a écrit : > > >I think a source distribution should contain the raw, unprocessed source > files. > > What do you mean by "raw"? > > If I check out the same repository on Windows and macOS, I would get > **different** file contents for *.java files. > Windows machine would check out files as CRLF, and macOS would checkout the > same files as LF. > > It is something that is controlled with > https://github.com/apache/calcite-avatica/blob/512bbee4aa24ef9fb8106d0286d1243679dce2d0/.gitattributes#L2 > > Vladimir
