I think CALCITE-3713 is overall a positive change. We have seen the number of rule applies are reduced in our test (not significant though). After fixing the performance issue, CALCITE-3713 is fine and IMO it should stay. Having say that, I understand the pain of updating test base line. So adding an option is reasonable too.
> On Feb 16, 2020, at 7:33 PM, Danny Chan <[email protected]> wrote: > > Hi, fellows, can we gave a solution here to solve the problem ? This is a > blocking issue from the Apache Flink side, we rely heavily on the digest for > plan tests. > > I have 2 solutions here: > > > 1. Revert the change of CALCITE-3713 > 2. We add a config option to switch the feature off > > Either is okey for me, I just need a conclusion ~ > > > Best, > Danny Chan > 在 2020年2月14日 +0800 PM2:54，Vladimir Sitnikov <[email protected]>，写道： >> The subject of the mail does not match the body. >> >> Please double check and ensure you mention a single change. >> >> >> PS if you use explain_digest attributes, it means you expect it might >> change due to implementation details. >> >> Vladimir
