It's good to find bugs like this, but it's depressing to only be finding them in RC3. The bug probably existed in RC0, RC1 and RC2. If there are lots of release iterations our volunteers start to burn out.
Folks, if you have an extensive test suite please run it as early in the process as you can, and log any bugs that you find. A week or two before RC0 is ideal. Danny, if's your call as RM, but I suggest that you let this RC run for several days, even if we find show-stoppers, to flush out as many issues as possible. Regarding 3839. It's a regression, it's probably a show-stopper, and I probably caused it. Lastly, the tag format is now "v<version>-rc<n>". In the past we have had other formats, such as "rel/calcite-<version>" and "calcite-<version>". Can we keep it consistent please? Julian On Mon, Mar 2, 2020 at 10:17 AM Anton Haidai <[email protected]> wrote: > > Hello, > > Local Calcite build with tests enabled on Linux: *OK* > Calcite-based system (Zoomdata) test suite: *FAIL* > > Our test suite detected a regression. It is easily reproducible in a unit > test. This test works fine in 1.21 branch. > https://issues.apache.org/jira/browse/CALCITE-3839 > > Vote: > 0 (non-binding) > > On Mon, Mar 2, 2020 at 3:28 PM Danny Chan <[email protected]> wrote: > > > Hi all, > > > > I have created a build for Apache Calcite 1.22.0, release > > candidate 3. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > https://github.com/apache/calcite/blob/v1.22.0-rc3/site/_docs/history.md > > > > The commit to be voted upon: > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > Its hash is 537b8dbb4b58c61b6c573eb07a51b8d38896a1ff > > > > Tag: > > https://github.com/apache/calcite/tree/v1.22.0-rc3 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.22.0-rc3 > > (revision 38350) > > > > The hashes of the artifacts are as follows: > > > > a7dface824287756fcc66f6f075286975e409e7ea9a0af97ad973f90bc2832250c09e0477bc571bd78f6ee3721883cce76cada9a3e9601e1dd497fb02679647f > > *apache-calcite-1.22.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1080/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/danny0405.asc > > https://www.apache.org/dist/calcite/KEYS > > > > N.B. > > To create the jars and test Apache Calcite: "./gradlew build". > > > > If you do not have a Java environment available, you can run the tests > > using docker. To do so, install docker and docker-compose, then run > > "docker-compose run test" from the root of the directory. > > > > Please vote on releasing this package as Apache Calcite 1.22.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.22.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > > > Here is my vote: > > > > +1 (binding) > > > > Best, > > Danny Chan > > > > > -- > Best regards, > Anton.
