-1 for the revert, we should fix the issues we encountered instead of reverting the code brainless for a whole release.
At lease, project like Apache Flink has upgrade to version 1.26 and the Sarg feature overall looks good. We are trying to fix the Sarg issues in version 1.27 and we should continue with that. So, logger the fail cases with issues and fix them, that is the way to go. Vladimir Sitnikov <[email protected]> 于2020年11月9日周一 上午7:41写道： > Stamatis>People who are responsible for upgrading Calcite, tend to follow > the dev > Stamatis>list so they can take the necessary actions. > > I think behind the lines of updating https://calcite.apache.org/news/ > > We might want to mention the following regressions, and we might want to > mark the release as unstable/broken > since there's no workaround: > [CALCITE-4352] RexSimplify incorrectly drops IS NULL and IS NOT NULL from > SEARCH expressions > [CALCITE-4325] RexSimplify incorrectly simplifies complex expressions that > contain Sarg and IS NULL > [CALCITE-4173], fix assertion error when RexSimplify generates Sarg with > single null only > > >Reverting the feature for the next release will necessitate further > actions > >on their side and it may be counter productive. > > Reverting the feature != reverting the feature for the next release. > It might be the feature will be ready by the next release. > > I just don't want to keep the code and tests broken. > There are lots of contributions landing to RexSimplify (which is nice, and > I love optimizations), > however, we have disabled RexProgramFuzzyTest long ago, and we really need > to re-enable it > otherwise, we would keep introducing regressions. > > Vladimir >
