I have the same feeling with Stamatis. I completely understand that Vladimir is trying to keep it working correctly. However, I know some downstream project already updated Calcite version and changed their code to adapt to the Sarg/SEARCH operator. Reverting it and in case we failed to fix the regressions you mentioned, if we release the new version without getting it back, there will be another major breaking change again. If that is the case, I would rather push for the fixes instead of revert before we can release next version.
Thanks, Haisheng Yuan On 2020/11/09 08:32:20, Vladimir Sitnikov <sitnikov.vladi...@gmail.com> wrote: > Danny>-1 for the revert, we should fix the issues we encountered instead of > Danny>reverting the code brainless for a whole release. > > Hi Danny, did you just veto the code change? (see > https://www.apache.org/foundation/voting.html#Veto ) > I am afraid I fail to find a technical justification behind the veto. > > Danny>So, logger the fail cases with issues and fix them, that is the way > to go. > > Thanks for the suggestion. I would tentatively decline it as it's going to > be difficult to find time to do this. > > Vladimir >
