Hi Julian, What is the proper way to fix release note/documentation suggestions given RC0 is under voting (I guess that does not require a RC1 cut)?
just push a new commit later to fix those things? -Rui On Mon, Dec 20, 2021 at 8:29 PM Julian Hyde <[email protected]> wrote: > Fixing the problem in the vote email previously noted by xiong duan: > > [ ] +1 Release this package as Apache Calcite 1.29.0 > > +1 > > Downloaded, checked hashes and signatures; compared files with git; > checked LICENSE, NOTICE; ensured no binaries in the tarball; built on > Ubuntu Linux, JDK 15 and Gradle 7.2 (per howto.md). > > Other remarks: > * howto.md should say Gradle 7.3 (since that’s out current Gradle version) > but says 7.2 > * I guess we now support JDK 16 and 17? According to the release notes, we > only go up to JDK 15. > * The commit message of > https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e > < > https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e> > should not end in ‘.’. > * The release notes need significant work: > * For contributors, list only names (not email addresses), remove > duplicates, and end each line with ‘,’ (last line with ‘.’) > * Change lines should not end in ‘,’ > * Add a ‘New features’ section > * In the change lines, manually put backticks around references such as > ARRAY_CONCAT and SqlBasicCall > * Use editorial discretion to make the release notes clearer. For > example, it is confusing that the release notes includes 'Revert > Elasticsearch to 7.10.2’ without mentioning the previous upgrade. I would > say ‘Upgrade Elasticsearch to 7.10.2’. Also omit the ‘ Upgrade log4j2 > version to 2.15.0’ and 'Upgrade log4j2 version to 2.16.0’ lines, because > they are superseded. > * 'Build gives lots of 'Execution optimizations have been disabled' > warnings,’ should be in ‘Build’ section > * We need more of a ‘headline’ than 'This release comes two months after > 1.28.0, contains contributions from 23 authors, and resolves 47 issues’ . I > would definitely mention the upgrade to log4j2. Others at your discretion. > > Julian > > > > On Dec 20, 2021, at 5:27 PM, Rui Wang <[email protected]> wrote: > > > > Hi all, > > > > I have created a build for Apache Calcite 1.29.0, release > > candidate 0. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md > > > > The commit to be voted upon: > > > https://github.com/apache/calcite/commit/cbfe0609edcc4a843d71497f159e3687a834119e > > > > Its hash is cbfe0609edcc4a843d71497f159e3687a834119e > > > > The artifacts to be voted on are located here: > > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.29.0-rc0/ > > (revision 51667) > > > > The hashes of the artifacts are as follows: > > > 7a59a30d0cab7b5edfcb71b960fc932de77b92f6e5863a99c721b61915805933e717a209dca880e46092d595920ba24485474f0c3b6715d152c900c0d95348b3 > > *apache-calcite-1.29.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > https://repository.apache.org/content/repositories/orgapachecalcite-1127/org/apache/calcite/ > > > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/amaliujia.asc > > https://www.apache.org/dist/calcite/KEYS > > > > To create the jars and test Apache Calcite: "gradle build" (requires an > > appropriate Gradle/JDK installation). > > > > Please vote on releasing this package as Apache Calcite 1.29.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.27.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > >
