Thank you! To ensure that JDK 16 and 17 are tested I believe you should edit either https://github.com/apache/calcite/blob/master/.github/workflows/main.yml or https://github.com/apache/calcite/blob/master/.travis.yml.
On Tue, Dec 21, 2021 at 3:45 PM Zhe Hu <[email protected]> wrote: > > Hi, Julian. > I’m happy to do those tasks. > Just one question, where or how can I ensure CI tests for JDK16 and JDK17. > > > Best, > > | > Zhe Hu > | > ---- Replied Message ---- > | From | Julian Hyde<[email protected]> | > | Date | 12/22/2021 07:37 | > | To | [email protected]<[email protected]> | > | Subject | [DISCUSS] Java 16 and 17 support | > Does Calcite now support Java 16 and 17? If think it probably does, > because of these three commits: > * > https://github.com/apache/calcite/commit/6d51d277b158ff7073f29ada4a96a7a74c0b46fc > * > https://github.com/apache/calcite/commit/dff775d24ae6f8b2e0f3b68fd727ef16fc9cb428 > * > https://github.com/apache/calcite/commit/a8a6569e6ba75efe9d5725c49338a7f181d3ab5c > / https://issues.apache.org/jira/browse/CALCITE-4829 > > However, as of 1.29 RC0 the release notes still say 'This release is > tested on Linux, macOS, Microsoft Windows; using JDK/OpenJDK versions > 8 to 15' [1]. > > The Gradle wrapper uses version 7.3 but the HOWTO still says to use > Gradle 7.2. I don't know whether Vladimir simply forgot to update > howto.md when he made commit 6d51d277 or deliberately did not, because > (in his words [2]) "Manual updates of the version in howto.md is one > of the worst ways to spend time on Calcite." > > Anticipating that Vladimir would fail to update howto.md, I added the > instructions "Check that site/_docs/howto.md has the correct Gradle > version" [3] but Rui failed to follow those instructions when making > 1.29 RC 0. > > If Calcite does indeed support JDK 16 and 17, then the following tasks > need to be done: > * Update the Gradle version in howto.md > * Add JDK 16 and 17 to history.md > * Ensure there are sufficient CI tests for JDK 16 and 17 > * Change the subject of > https://issues.apache.org/jira/browse/CALCITE-4547 to "Support Java 16 > and 17", mark it fixed in release 1.29, and retrospectively add it to > 1.29's release notes. > > Any volunteers to do some or all of these tasks? > > Julian > > [1] > https://github.com/apache/calcite/blob/calcite-1.29.0-rc0/site/_docs/history.md > > [2] > https://issues.apache.org/jira/browse/CALCITE-4575?focusedCommentId=17340363&page=com.atlassian.jira.plugin.system.issuetabpanels%3Acomment-tabpanel#comment-17340363 > > [3] > https://github.com/apache/calcite/blob/master/site/_docs/howto.md#making-a-release-candidate > >
