Liya, in the next iteration can you go back to the usual sections e.g “Bug-fixes, API changes and minor enhancements”. Also remove the “Fix” prefix from messages.
Quite a few cases, e.g “ Fix the problem that JDBC adapter incorrectly adds ORDER BY columns to the SELECT list of generated SQL query” are in the gray area between bug and missing feature, and using the original message helps people make their own decision. I also think there’s value in putting changes to build and test in a separate section, as we used to do. But please move my “Fluent test fixtures” into the “new features” section - because it is a major new feature. Julian > On Mar 6, 2022, at 10:31 PM, Francis Chuang <[email protected]> wrote: > > Thanks so much Liya! Please cancel this vote by sending a [CANCEL] message > as well, to formalize the cancellation of this vote. > > Francis > >> On 7/03/2022 5:27 pm, Fan Liya wrote: >> After some investigation, I could not resolve the 404 issue of the commit >> link (In my computer, it is not 404, but an error with XML format). >> So I have created a new build, which has resolved all the above issues >> (according to the test on my local computer). >> Let's start another vote based on the new build. Thanks. >> Best, >> Liya Fan >> Fan Liya <[email protected]> 于2022年3月7日周一 09:53写道： >>> Thanks for your feedback, Francis. >>> I will check. >>> >>> Best, >>> Liya Fan >>> >>> >>> Francis Chuang <[email protected]> 于2022年3月7日周一 09:36写道： >>> >>>> Hey Liya, >>>> >>>> Thanks for being RM for this release. >>>> >>>> Can you check the commit to be voted upon? >>>> >>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e >>>> returns a 404 >>>> >>>> Also, tag calcite-1.30.0-rc0 points to a39b9bf >>>> (https://github.com/apache/calcite/releases/tag/calcite-1.30.0-rc0), >>>> which does not seem to be in the Calcite repository, see: >>>> >>>> https://github.com/apache/calcite/commit/a39b9bf8b1cbab8f4462c41f6b4506753f859f96 >>>> >>>> Thanks! >>>> Francis >>>> >>>> On 5/03/2022 8:56 pm, Fan Liya wrote: >>>>> Hi all, >>>>> >>>>> I have created a build for Apache Calcite 1.30.0, release >>>>> candidate 0. >>>>> >>>>> Thanks to everyone who has contributed to this release. >>>>> >>>>> You can read the release notes here: >>>>> >>>> https://github.com/apache/calcite/blob/calcite-1.30.0-rc0/site/_docs/history.md >>>>> >>>>> The commit to be voted upon: >>>>> >>>> https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e >>>>> >>>>> Its hash is 28aacc0bbccfbcd821fece72ae3d92f6c1db8a5e >>>>> >>>>> Tag: >>>>> https://github.com/apache/calcite/tree/calcite-1.30.0-rc0 >>>>> >>>>> The artifacts to be voted on are located here: >>>>> >>>> https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.30.0-rc0 >>>>> (revision 52873) >>>>> >>>>> The hashes of the artifacts are as follows: >>>>> >>>> 339b279426abfc09a73b0daf94479127aa469b1cd3fa1b1cf0842f57d64daf0e080d4e85ccdd2d32032ed424a39388790743adf2aec869480612e37003eabfc5 >>>>> *apache-calcite-1.30.0-src.tar.gz >>>>> >>>>> A staged Maven repository is available for review at: >>>>> >>>> https://repository.apache.org/content/repositories/orgapachecalcite-1148/org/apache/calcite/ >>>>> >>>>> Release artifacts are signed with the following key: >>>>> https://people.apache.org/keys/committer/COMMITTER_ID.asc >>>>> https://www.apache.org/dist/calcite/KEYS >>>>> >>>>> To create the jars and test Apache Calcite: "gradle build" >>>>> (requires an appropriate Gradle/JDK installation) >>>>> >>>>> Please vote on releasing this package as Apache Calcite 1.30.0. >>>>> >>>>> The vote is open for the next 72 hours and passes if a majority of at >>>>> least three +1 PMC votes are cast. >>>>> >>>>> [ ] +1 Release this package as Apache Calcite 1.30.0 >>>>> [ ] 0 I don't feel strongly about it, but I'm okay with the release >>>>> [ ] -1 Do not release this package because... >>>>> >>>>> Here is my vote: >>>>> >>>>> +1 (binding) >>>>> >>>>> Best, >>>>> Liya Fan >>>>> >>>> >>>
