Thank you, Alessandro and Stamatis, for the info. Currently, the guava version being used in druid is 16. So simple exclusion is unlikely to work. I will still give it a try. If it doesn't, we will shade the jars on our end.
On Tue, Mar 29, 2022 at 3:38 PM Alessandro Solimando < alessandro.solima...@gmail.com> wrote: > Hello Abhishek, > maybe I am re-stating what Stamatis suggested without realising, but since > Calcite works well with a broad range of guava versions, can't you simply > exclude guava when you include it in druid? > > At that point if the guava version of druid is in the list of those > supported by Calcite (>= 19 IIRC) all should work fine. > > I feel like Stamatis concerning shading. > > Best regards, > Alessandro > > On Tue, 29 Mar 2022 at 11:18, Stamatis Zampetakis <zabe...@gmail.com> > wrote: > > > Hi Abhishek, > > > > Calcite supports multiple versions of Guava so in principle it should > work > > without problems with older versions. > > Instead of shading you could possibly select explicitly the version > > that you want to use via maven/gradle. > > > > I share your pain but shading is quite complex to get right so I am not > in > > favor of putting this burden on Calcite. > > > > I've seen it used in many projects and it rarely works as expected. Most > of > > the time it creates additional problems that need to be resolved. > > > > Best, > > Stamatis > > >
