Alessandro Solimando created CALCITE-5340:
---------------------------------------------

             Summary: Tests should fail when actual and expected XML files are 
not identical
                 Key: CALCITE-5340
                 URL: https://issues.apache.org/jira/browse/CALCITE-5340
             Project: Calcite
          Issue Type: Bug
          Components: build, tests
    Affects Versions: 1.32.0
            Reporter: Alessandro Solimando


Calcite has several XML reference files for tests.

When a new test is added, those files should be updated by copying the new, 
automatically-generated, version.

Sometimes the files are updated manually, and differ from the automatic 
generation, which makes it harder for the next developer to rely on automatic 
generation.

Following the 
[discussion|https://lists.apache.org/thread/m567vhcmxyt7thprbs22botpnvjg98mj] 
in the ML, it is desirable to have tests failing upon discrepancies.

This ticket aims at tracking the effort towards this goal.

_DiffRepository_ class is responsible for diffing, so it's the first candidate 
to consider for adding such a check.



--
This message was sent by Atlassian Jira
(v8.20.10#820010)

Reply via email to