Yes, it's still frozen until further notice. Thanks Jiajun for spotting it, and Tanner for volunteering to help revert it.
Tanner Clary <tannercl...@google.com.invalid> 于2023年11月8日周三 10:35写道： > > I can revert it if that's alright, hope this helps! > > Best, > Tanner > > On Tue, Nov 7, 2023 at 6:01 PM Francis Chuang <francischu...@apache.org> > wrote: > > > I believe the main branch should still be frozen as we're still voting > > for 1.36.0. > > > > I think 14ed78f22eb854fe4643c6e1faad5b0824733515 needs to be reverted > > and then rebased on to main after 1.36.0 has been released. > > > > Francis > > > > On 8/11/2023 12:58 pm, Jiajun Xie wrote: > > > Hi, Benchao > > > > > > Is the main branch still frozen? > > > > > > I found a new commit[1], but 1.36.0 has not been released. > > > > > > [1] > > > > > https://github.com/apache/calcite/commit/3157408a127de0d5c1d6b440bd2086f96f4f91ba > > > > > > On Mon, 6 Nov 2023 at 14:59, Benchao Li <libenc...@apache.org> wrote: > > > > > >> The release note PR is now available for review: > > >> https://github.com/apache/calcite/pull/3505 > > >> > > >> Benchao Li <libenc...@apache.org> 于2023年11月6日周一 12:46写道： > > >>> > > >>> Hi devs, > > >>> > > >>> All the issues targeted for 1.36.0 have been resolved, I'll start the > > >>> release process now. Therefore main branch is in code freeze until > > >>> further notice. > > >>> > > >>> Benchao Li <libenc...@apache.org> 于2023年11月3日周五 10:50写道： > > >>>> > > >>>> @Mihai @Julian The only left issue is 5884 now, can we merge it and > > >>>> start the releasing process? > > >>>> > > >>>> LakeShen <shenleifight...@gmail.com> 于2023年11月1日周三 12:13写道： > > >>>>> > > >>>>> Hi Itiel, > > >>>>> > > >>>>> I have reviewd the https://github.com/apache/calcite/pull/3325,and > > >> left one > > >>>>> comments > > >>>>> > > >>>>> Benchao Li <libenc...@apache.org> 于2023年11月1日周三 10:17写道： > > >>>>> > > >>>>>> Mihai, > > >>>>>> I've reviewed 5884, it looks good and I think we can have it in > > >> 1.36.0 > > >>>>>> > > >>>>>> Itiel, > > >>>>>> https://github.com/apache/calcite/pull/3325 has been reviewed and > > >> even > > >>>>>> with an approval, I'll try to ping in the PR to try to get it > > >> merged > > >>>>>> in 1.36.0 > > >>>>>> > > >>>>>> Mihai Budiu <mbu...@gmail.com> 于2023年11月1日周三 02:42写道： > > >>>>>>> > > >>>>>>> 5884 is mostly documentation fixes. > > >>>>>>> I expected it would be easy to get it in. > > >>>>>>> But we can leave it for later. > > >>>>>>> > > >>>>>>> Mihai > > >>>>>>> > > >>>>>>> ________________________________ > > >>>>>>> From: Benchao Li <libenc...@apache.org> > > >>>>>>> Sent: Tuesday, October 31, 2023 6:50 AM > > >>>>>>> To: dev@calcite.apache.org <dev@calcite.apache.org> > > >>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > >>>>>>> > > >>>>>>> Due to the inactivity of the review for CALCITE-5884 and > > >> CALCITE-4455, > > >>>>>>> I think we can move it out of 1.36.0 for now. What do you think? > > >>>>>>> > > >>>>>>> Other three issues look promising to be merged soon, then I'll > > >> start > > >>>>>>> the release process after they are merged. > > >>>>>>> > > >>>>>>> Julian Hyde <jhyde.apa...@gmail.com> 于2023年10月31日周二 02:31写道： > > >>>>>>>> > > >>>>>>>> I just merged CALCITE-{129,6052}. Five left. > > >>>>>>>> > > >>>>>>>>> On Oct 30, 2023, at 7:22 AM, Ran Tao <chucheng...@gmail.com> > > >> wrote: > > >>>>>>>>> > > >>>>>>>>> The expected release time at the end of the month seems to > > >> be coming > > >>>>>> soon. > > >>>>>>>>> I performed an update on the list compiled by Jiajun. > > >>>>>>>>> > > >>>>>>>>> #1.Last update (new comments or commits) within 2 days > > >> (almost > > >>>>>> ready): > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-129 > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5826 > > >>>>>>>>> > > >>>>>>>>> #2. Last update exceeded 2 days > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5990 > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5984 > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6052 > > >>>>>>>>> > > >>>>>>>>> #3. Last update exceeded 7 days > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5884 > > >>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-4455 > > >>>>>>>>> > > >>>>>>>>> Best Regards, > > >>>>>>>>> Ran Tao > > >>>>>>>>> > > >>>>>>>>> > > >>>>>>>>> Jiajun Xie <jiajunbernou...@gmail.com> 于2023年10月28日周六 > > >> 13:34写道： > > >>>>>>>>> > > >>>>>>>>>> Hi, all: > > >>>>>>>>>> We're already very close to 1.36.0, all unresolved issues > > >> has been > > >>>>>> someone > > >>>>>>>>>> reviewed. > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>> > > >> > > https://issues.apache.org/jira/browse/CALCITE-6047?jql=project%20%3D%20CALCITE%20AND%20status%20%3D%20Open%20AND%20fixVersion%20%3D%201.36.0 > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> - Some issues are currently being reviewed. > > >>>>>>>>>> That's great! Thank you all for your efforts. > > >>>>>>>>>> - Some issues have not been updated for a long time. > > >>>>>>>>>> If anyone is willing to continue the review, I believe they > > >> should > > >>>>>> be > > >>>>>>>>>> resolved soon. > > >>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>>>> #1.Last update (new comments or commits) within 2 days: > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-129 > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5990 > > >>>>>>>>>> > > >>>>>>>>>> #2. Last update exceeded 2 days > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5984 > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6052 > > >>>>>>>>>> > > >>>>>>>>>> #3. Last update exceeded 7 days > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5884 > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6037 > > >>>>>>>>>> > > >>>>>>>>>> #4. Last update exceeded 14 days > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-4455 > > >>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5826 > > >>>>>>>>>> > > >>>>>>>>>> On Wed, 25 Oct 2023 at 11:40, Benchao Li < > > >> libenc...@apache.org> > > >>>>>> wrote: > > >>>>>>>>>> > > >>>>>>>>>>> Thanks Mihai for the quick response, I'll take a look at > > >> the PR. > > >>>>>>>>>>> > > >>>>>>>>>>> Mihai Budiu <mbu...@gmail.com> 于2023年10月25日周三 05:02写道： > > >>>>>>>>>>>> > > >>>>>>>>>>>> For the blocker issues, I have filed two PRs which should > > >>>>>> collectively > > >>>>>>>>>>> fix them. > > >>>>>>>>>>>> > > >>>>>>>>>>>> https://github.com/apache/calcite/pull/3481 fixes > > >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5990, but > > >> does not > > >>>>>> include > > >>>>>>>>>>> tests, because the test fixture needs to be fixed as well > > >> for the > > >>>>>> tests > > >>>>>>>>>> to > > >>>>>>>>>>> pass. There are tests in the next PR: > > >>>>>>>>>>>> https://github.com/apache/calcite/pull/3471 fixes > > >>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5921, but > > >> should be > > >>>>>>>>>> amended > > >>>>>>>>>>> to reenable the disabled tests if we merge 3481 first. > > >>>>>>>>>>>> > > >>>>>>>>>>>> Mihai > > >>>>>>>>>>>> > > >>>>>>>>>>>> ________________________________ > > >>>>>>>>>>>> From: Benchao Li <libenc...@apache.org> > > >>>>>>>>>>>> Sent: Tuesday, October 24, 2023 5:46 AM > > >>>>>>>>>>>> To: dev@calcite.apache.org <dev@calcite.apache.org> > > >>>>>>>>>>>> Subject: Re: [DISCUSS] Towards Calcite 1.36.0 > > >>>>>>>>>>>> > > >>>>>>>>>>>> A quick update on the current status for issues targeted > > >> 1.36.0 > > >>>>>>>>>>>> > > >>>>>>>>>>>> We need more reviewers for #2 and #3 since the end of > > >> October is > > >>>>>>>>>>> approaching. > > >>>>>>>>>>>> Please correct me if I'm mistaken, especially for issues > > >> in #1. > > >>>>>>>>>>>> > > >>>>>>>>>>>> #1. Issues already have reviewers, and seems promising to > > >> be > > >>>>>> merged > > >>>>>>>>>>> shortly > > >>>>>>>>>>>> > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5884 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5918 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5860 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6011 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5949 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6041 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6038 > > >>>>>>>>>>>> > > >>>>>>>>>>>> #2. Issues has been reviewed, and needs another reviewer > > >>>>>>>>>>>> > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5984 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5825 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5826 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6037 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-4455 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6042 > > >>>>>>>>>>>> > > >>>>>>>>>>>> #3. PR is ready, no reviewer yet > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-6052 > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-129 > > >>>>>>>>>>>> > > >>>>>>>>>>>> #4. blocker issues status > > >>>>>>>>>>>> https://issues.apache.org/jira/browse/CALCITE-5990 is > > >> marked > > >>>>>> blocked > > >>>>>>>>>>>> by https://issues.apache.org/jira/browse/CALCITE-5921 > > >> now. > > >>>>>>>>>>>> Both issues have a PR, but proposed to have a more > > >> thorough > > >>>>>> solution. > > >>>>>>>>>>>> I'll keep an eye on them closely. > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> Ran Tao <chucheng...@gmail.com> 于2023年10月18日周三 18:37写道： > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Hi, community. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Recently I reported an issue[1] which revealed that > > >> calcite's MAP > > >>>>>>>>>>> SubQuery > > >>>>>>>>>>>>> doesn't work, > > >>>>>>>>>>>>> considering this is a feature regression or bug, maybe > > >> we can > > >>>>>> fix it > > >>>>>>>>>> in > > >>>>>>>>>>>>> 1.36. > > >>>>>>>>>>>>> The PR is ready. If someone has time, pls help to review > > >> it. many > > >>>>>>>>>>> thanks. > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> [1] https://issues.apache.org/jira/browse/CALCITE-6041 > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Best Regards, > > >>>>>>>>>>>>> Ran Tao > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> > > >>>>>>>>>>>>> Benchao Li <libenc...@apache.org> 于2023年10月8日周日 11:02写道： > > >>>>>>>>>>>>> > > >>>>>>>>>>>>>> It's been a bit more than 2 months since our last > > >> release [1] > > >>>>>> and > > >>>>>>>>>>>>>> there are currently 90+ new commits in main branch. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> As usual, according to our Jira dashboard [2] and > > >> Github [3], > > >>>>>> there > > >>>>>>>>>>>>>> are many pending issues that could / should be part of > > >> the > > >>>>>> release. > > >>>>>>>>>>>>>> I'd propose to make a collective effort to try to clean > > >> up our > > >>>>>> 1.36 > > >>>>>>>>>>>>>> backlog and merge the PRs which are in a good state. I'd > > >>>>>> propose to > > >>>>>>>>>>>>>> aim for **end of October** to release 1.36.0, this will > > >> give us > > >>>>>>>>>> about > > >>>>>>>>>>>>>> 20 days to clean up pending PRs for next version. What > > >> do you > > >>>>>>>>>> think? > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> According to [4], the following release managers would > > >> be: > > >>>>>>>>>>>>>> - 1.36.0 Benchao Li > > >>>>>>>>>>>>>> - 1.37.0 Sergey Nuyanzin > > >>>>>>>>>>>>>> - 1.38.0 Julian Hyde > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> So I'm supposed to be the release manager for 1.36.0 > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> And contributors, if you have any work that is in good > > >> shape and > > >>>>>>>>>> want > > >>>>>>>>>>>>>> to be included in 1.36.0, please mark the fixVersion to > > >> 1.36.0, > > >>>>>>>>>> this > > >>>>>>>>>>>>>> will inform the release manager, and we'll try our best > > >> to get > > >>>>>> it > > >>>>>>>>>> in. > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> CALCITE-5990[5] is marked as a blocker since it's > > >> introduced by > > >>>>>>>>>>>>>> CALCITE-5843[6], could @Mihai help to double check > > >> whether it > > >>>>>> is a > > >>>>>>>>>>>>>> expected change, and we need to fix it within 1.36.0? > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> [1] > > >> https://calcite.apache.org/docs/history.html#v1-35-0 > > >>>>>>>>>>>>>> [2] > > >>>>>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>> > > >> > > https://issues.apache.org/jira/secure/Dashboard.jspa?selectPageId=12333950 > > >>>>>>>>>>>>>> [3] https://github.com/apache/calcite/pulls > > >>>>>>>>>>>>>> [4] > > >>>>>>>>>> > > >> https://lists.apache.org/thread/tm3t42qvpq3db24xtd2g468ofv83l6hk > > >>>>>>>>>>>>>> [5] https://issues.apache.org/jira/browse/CALCITE-5990 > > >>>>>>>>>>>>>> [6] https://issues.apache.org/jira/browse/CALCITE-5843 > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> -- > > >>>>>>>>>>>>>> > > >>>>>>>>>>>>>> Best, > > >>>>>>>>>>>>>> Benchao Li > > >>>>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> > > >>>>>>>>>>>> -- > > >>>>>>>>>>>> > > >>>>>>>>>>>> Best, > > >>>>>>>>>>>> Benchao Li > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> > > >>>>>>>>>>> -- > > >>>>>>>>>>> > > >>>>>>>>>>> Best, > > >>>>>>>>>>> Benchao Li > > >>>>>>>>>>> > > >>>>>>>>>> > > >>>>>>>> > > >>>>>>> > > >>>>>>> > > >>>>>>> -- > > >>>>>>> > > >>>>>>> Best, > > >>>>>>> Benchao Li > > >>>>>> > > >>>>>> > > >>>>>> > > >>>>>> -- > > >>>>>> > > >>>>>> Best, > > >>>>>> Benchao Li > > >>>>>> > > >>>> > > >>>> > > >>>> > > >>>> -- > > >>>> > > >>>> Best, > > >>>> Benchao Li > > >>> > > >>> > > >>> > > >>> -- > > >>> > > >>> Best, > > >>> Benchao Li > > >> > > >> > > >> > > >> -- > > >> > > >> Best, > > >> Benchao Li > > >> > > > > > -- Best, Benchao Li
