I merged the PR. Thank you for the contribution!

> On Jan 11, 2024, at 12:16 PM, Paul Jackson 
> <[email protected]> wrote:
> 
> I fixed the checker framework problems. One of the last ones - continuous 
> integration - ran out of memory. Is that flakiness or something I need to fix?
> 
> Thanks,
> -Paul
> 
> 
> On Monday, January 8, 2024 at 05:41:30 PM EST, Julian Hyde <[email protected]> 
> wrote:
> 
> 
> 
> I see two failures due to checkerframework. Those are real. Let us
> know when you've fixed them.
> 
> The failure in Druid is probably due to a Druid bug that existed in
> November. You can ignore it. Should go away after rebase.
> 
> Please keep nagging on this thread... this is a good change, and we
> should get it into 1.37.
> 
> On Mon, Jan 8, 2024 at 11:34 AM Mihai Budiu <[email protected]> wrote:
>> 
>> CI failed, so perhaps you can look into that.
>> 
>> Mihai
>> ________________________________
>> From: Paul Jackson <[email protected]>
>> Sent: Monday, January 8, 2024 7:06 AM
>> To: [email protected] <[email protected]>
>> Subject: Re: PR 3495 (Make single-row rels unique) Review Request
>> 
>> Is there anything else to do for this PR?
>> 
>> * https://github.com/apache/calcite/pull/3495
>> * https://issues.apache.org/jira/browse/CALCITE-6044
>> 
>> Thanks,
>> -Paul
>> 
>> 
>>> On Nov 16, 2023, at 7:51 AM, Paul Jackson 
>>> <[email protected]> wrote:
>>> 
>>> This PR updates org.apache.calcite.rel.metadata areColumnsUnique,
>>> getUniqueKeys, and getPredicates methods to account for relations that 
>>> produce at most a single row: Sort (due to limit), Aggregate (due to no 
>>> group by), Values (due to having a single row), and Join (when joining with 
>>> one of the other nodes).
>>> https://github.com/apache/calcite/pull/3495https://issues.apache.org/jira/projects/CALCITE/issues/CALCITE-6044
>>> Thanks,-Paul

Reply via email to