Thanks for testing Guillaume >Sergey can you give me all the details about your build environment so I >can reproduce that bytecode? >OS / java --version yep, sure Ubuntu 22.04.4 LTS, 1.8.0_372-372 (OpenLogic-OpenJDK 25.372-b07)
I will also try to look at it with my set up and the info you've provided On Mon, Apr 29, 2024 at 8:03 PM Guillaume Masse <masse.guilla...@narrative.io.invalid> wrote: > -1 (not binding) > > The bytecode of classfile org/apache/calcite/runtime/SqlFunctions.class is > invalid (and only this classfile) > > I tested all class files from the following artifacts: > calcite-core-1.37.0.jar > calcite-linq4j-1.37.0.jar > avatica-core-1.25.0.jar > avatica-metrics-1.25.0.jar > > This will prevent bytecode tools like asm (https://asm.ow2.io/) from > transforming calcite bytecode (for example shading a dependency). > > See > https://gitlab.ow2.org/asm/asm/-/issues/318008 > https://lists.apache.org/thread/nrt4ysoc14p20sq23z744jyfqh1bznyh > > To reproduce > https://github.com/MasseGuillaume/asm-remapper-bug > > Sergey can you give me all the details about your build environment so I > can reproduce that bytecode? > OS / java --version > > I do not have the root cause of the issue. > I suspect it's related to import > org.checkerframework.checker.nullness.qual.Nullable > > > > > > On Mon, Apr 29, 2024 at 10:56 AM Sergey Nuyanzin <snuyan...@gmail.com> > wrote: > > > Hi all, > > > > The issue CALCITE-6390 with failing of Arrow Adapter tests on Windows > while > > building from source is fixed. > > Thanks a lot to Caican Can for highlighting the issue > > Stamatis for quick PR > > and Ruben and Alessandro for the review! > > > > I have created a build for Apache Calcite 1.37.0, release > > candidate 4. > > > > Thanks to everyone who has contributed to this release. > > > > You can read the release notes here: > > > > > https://github.com/apache/calcite/blob/calcite-1.37.0-rc4/site/_docs/history.md > > > > The commit to be voted upon: > > > > > https://gitbox.apache.org/repos/asf?p=calcite.git;a=commit;h=044db3d72ee53c1a82ce68b0c2a9b4f0bed81f18 > > > > Its hash is 044db3d72ee53c1a82ce68b0c2a9b4f0bed81f18 > > > > Tag: > > https://github.com/apache/calcite/tree/calcite-1.37.0-rc4 > > > > The artifacts to be voted on are located here: > > https://dist.apache.org/repos/dist/dev/calcite/apache-calcite-1.37.0-rc4 > > (revision 68857) > > > > The hashes of the artifacts are as follows: > > > > > a6ae7ea1ebbab3e5b723122c9517412d74b6bccba9fb41d360f7c2262ed7f26e5a4cc861a711d4813d27d72a0ffd086ae3a9175abc3c874b079137c84d13f83a > > *apache-calcite-1.37.0-src.tar.gz > > > > A staged Maven repository is available for review at: > > > > > https://repository.apache.org/content/repositories/orgapachecalcite-1230/org/apache/calcite/ > > > > Release artifacts are signed with the following key: > > https://people.apache.org/keys/committer/snuyanzin.asc > > https://www.apache.org/dist/calcite/KEYS > > > > To create the jars and test Apache Calcite: "gradle build" > > (requires an appropriate Gradle/JDK installation) > > > > Please vote on releasing this package as Apache Calcite 1.37.0. > > > > The vote is open for the next 72 hours and passes if a majority of at > > least three +1 PMC votes are cast. > > > > [ ] +1 Release this package as Apache Calcite 1.37.0 > > [ ] 0 I don't feel strongly about it, but I'm okay with the release > > [ ] -1 Do not release this package because... > > > > Here is my vote: > > > > +1 (binding) > > > > > > -- > > Best regards, > > Sergey > > > -- Best regards, Sergey
